Messages in this thread |  | | Date | Wed, 18 Apr 2018 11:03:14 +0200 | From | Michal Hocko <> | Subject | Re: [v4 PATCH] mm: introduce arg_lock to protect arg_start|end and env_start|end in mm_struct |
| |
On Wed 18-04-18 12:02:17, Cyrill Gorcunov wrote: > On Wed, Apr 18, 2018 at 10:05:55AM +0200, Michal Hocko wrote: > > > > Yes, looks good to me. As mentioned in other emails prctl_set_mm_map > > really deserves a comment explaining why we are doing the down_read > > > > What about something like the following? > > " > > arg_lock protects concurent updates but we still need mmap_sem for read > > to exclude races with do_brk. > > " > > Acked-by: Michal Hocko <mhocko@suse.com> > > Yes, thanks! Andrew, could you slightly update the changelog please?
No, I meant it to be a comment in the _code_.
-- Michal Hocko SUSE Labs
|  |