Messages in this thread |  | | Subject | Re: [PATCH v5 2/7] clk: meson: aoclk: refactor common code into dedicated file | From | Jerome Brunet <> | Date | Tue, 17 Apr 2018 16:15:33 +0200 |
| |
On Tue, 2018-04-17 at 16:16 +0800, Yixun Lan wrote: > Hi Jerome > > On 04/16/18 18:38, Jerome Brunet wrote: > > > + */ > > > + for (clkid = 0; clkid < data->num_clks; clkid++) { > > > + data->clks[clkid]->map = regmap; > > > + > > > + ret = devm_clk_hw_register(dev, data->hw_data->hws[clkid]); > > > + if (ret) > > > + return ret; > > > + } > > > + > > > + return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, > > > + (void *) data->hw_data); > > > +} > > > > Missing new line here. Please run checkpatch and pay attention to git warnings > > about whitespace errors. > > >
Google this if you want, As far as I know the C language requires it and makes things nice when I cat the file.
Anyway, I don't make those rules, It is just how it is.
> > I think we actually need to avoid this extra new line, or what's the > benefits with new line? > > and besides, I didn't see any complaint from checkpatch.pl .. > > ./scripts/checkpatch.pl > 0002-clk-meson-aoclk-refactor-common-code-into-dedicated-.patch > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #235: > new file mode 100644 > > total: 0 errors, 1 warnings, 302 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or > --fix-inplace. > > 0002-clk-meson-aoclk-refactor-common-code-into-dedicated-.patch has > style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > > Yixun
|  |