Messages in this thread | | | From | Benjamin Tissoires <> | Date | Tue, 17 Apr 2018 14:56:03 +0200 | Subject | Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found |
| |
On Tue, Apr 17, 2018 at 2:11 PM, Jiri Kosina <jikos@kernel.org> wrote: > On Mon, 16 Apr 2018, Dmitry Torokhov wrote: > >> So what is happening with this series? I think we should get it them >> in; there is really no reason for bumping ABS_MISC till it gets into >> ABS_MT_* range on some devices that are out there. >> >> FWIW >> >> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Sorry, I somehow lost this one. Now queued for 4.18.
Thanks Jiri, and thanks Dmitry for the reminder.
Jiri, BTW, I have 2 patch locally that should mitigate the negative impact from this patch if there is any,
While trying to merging hid-multitouch into hid-core, I came to realize that hid-generic should probably split the HID collections by applications. If a device has a joystick and a mouse collection, there is no point merging these two collections together. This is the most common use case for reusing the same ABS_X value in one device.
I'll try to post the patches today, though I have some internal deadline :(
Cheers, Benjamin
| |