Messages in this thread | | | From | "Bean Huo (beanhuo)" <> | Subject | Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events | Date | Tue, 17 Apr 2018 12:09:26 +0000 |
| |
>On Mon, 2018-04-16 at 20:27 +0000, Bean Huo (beanhuo) wrote: >> By the way, these patches are not to add new feature, they are just to >> add print tag along with the other exist printed request parameters. > >Are you aware that there are two tag fields in struct request, namely "tag" >and "internal_tag"? Are you aware that how these fields are used depends on >whether or not a scheduler is attached to a request queue? Have you verified >that the "tag" field contains a meaningful value for blk-mq for every blk-mq >tracepoint? > >Thanks, > >Bart. > > Yes, I noticed and was aware, there are tag and internal_tag. One thing I was not aware is that the patches would make such a big impact on blk-mq based on Your comments.
I am not expert on block layer, that is why I added block maintainer here. Please point out which line and what is problem? If there is some wrong with the patch. Which one is correct "tag" to track request?
Thanks, //Bean Huo
| |