lkml.org 
[lkml]   [2018]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property has_axieth_connected
    Date
    Hi Vinod,

    > -----Original Message-----
    > From: Vinod Koul [mailto:vinod.koul@intel.com]
    > Sent: Wednesday, April 11, 2018 2:35 PM
    > To: Radhey Shyam Pandey <radheys@xilinx.com>; Rob Herring
    > <robh@kernel.org>; devicetree@vger.kernel.org
    > Cc: dan.j.williams@intel.com; michal.simek@xilinx.com; Appana Durga
    > Kedareswara Rao <appanad@xilinx.com>; Radhey Shyam Pandey
    > <radheys@xilinx.com>; lars@metafoo.de; dmaengine@vger.kernel.org;
    > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
    > Subject: Re: [RFC 1/6] dt-bindings: dma: xilinx_dma: Add optional property
    > has_axieth_connected
    >
    > On Mon, Apr 02, 2018 at 04:09:01PM +0530, Radhey Shyam Pandey wrote:
    > > Add an optional AXI DMA property 'has_axieth_connected'. This can be
    > > specified to indicate that AXI DMA is connected to AXI Ethernet in
    > > hardware design and dma driver needs to do some additional handling.
    >
    > 1. why are DT people and list not added to this? I have added that
    Sorry missed it. I will add in v2. Thanks.
    > 2. should we have a property for a specific peripheral? Wouldn't it help to
    > have
    > a generic property for peripheral connected which can be scaled to more IPs
    > being connected in future?
    Good point! I will rename this property to xlnx,axistream-connected and
    update description. It can then be reused for other usecases as well.
    > 3. Please use right subsystem name, it damengine: not dma:
    I will fix.
    >
    > >
    > > Signed-off-by: Radhey Shyam Pandey <radheys@xilinx.com>
    > > ---
    > > .../devicetree/bindings/dma/xilinx/xilinx_dma.txt | 1 +
    > > 1 files changed, 1 insertions(+), 0 deletions(-)
    > >
    > > diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > > index a2b8bfa..5d592e3 100644
    > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
    > > @@ -42,6 +42,7 @@ Optional properties:
    > > the hardware.
    > > Optional properties for AXI DMA:
    > > - xlnx,mcdma: Tells whether configured for multi-channel mode in the
    > hardware.
    > > +- xlnx,axieth-connected: Tells whether AXI DMA is connected to AXI
    > Ethernet.
    > > Optional properties for VDMA:
    > > - xlnx,flush-fsync: Tells which channel to Flush on Frame sync.
    > > It takes following values:
    > > --
    > > 1.7.1
    > >
    >
    > --
    > ~Vinod

    \
     
     \ /
      Last update: 2018-04-17 12:56    [W:2.342 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site