Messages in this thread | | | From | <> | Subject | RE: [SIL2review] [PATCH] i2c: img-scb: fix PM device usage count | Date | Tue, 17 Apr 2018 08:03:07 +0000 |
| |
Hi,
> Is it easily recognizable if the drivers check the error code because > there is a reason or if they do it "out of habit"?
Probably by looking closely at the implementation of the PM callouts for the driver, but I couldn't find a pattern that would be easy to recognize. Maybe I didn't look close enough ;-)
I concur that removing the check would be a better approach if it's clear that it's just done "out of habit".
Actually, the real problem is to find the drivers that need to have the check in, add/fix it for them, and remove it for all others.
Unfortunately, all I'm currently able to do is finding the parts that are inconsistent.
Tobias
| |