Messages in this thread | | | Date | Tue, 17 Apr 2018 14:16:38 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] tracing/x86: Update syscall trace events to handle new x86 syscall func names |
| |
On Tue, 17 Apr 2018 15:13:04 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Apr 17, 2018 at 03:04:30PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Apr 17, 2018 at 07:22:36PM +0200, Dominik Brodowski escreveu: > > > > Added back original compare to not miss 32bit kernel syscalls > > > > > > s/32bit/32bit and 0-parameter syscalls. > > > > So this should have covered 0-parameter syscalls, ok, I'm double > > checking that the last patch is the one I have running... Because > > 0-parameter syscalls are not working for me, i.e. no > > syscalls:sys_enter_getppid, for instance. > > Yeah, failing: > > [root@jouet ~]# strace -e openat -e file perf test -F -v "mmap interface" |& grep syscalls > openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getsid/format", O_RDONLY) = 3 > openat(AT_FDCWD, "/sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format", O_RDONLY) = -1 ENOENT (No such file or directory) > [root@jouet ~]# > > [root@jouet ~]# ls -la /sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format > ls: cannot access '/sys/kernel/debug/tracing/events/syscalls/sys_enter_getppid/format': No such file or directory > [root@jouet ~]# > > With: > > +#define ARCH_HAS_SYSCALL_MATCH_SYM_NAME > +static inline bool arch_syscall_match_sym_name(const char *sym, const char *name) > +{ > + /* > + * Compare the symbol name with the system call name. Skip the > + * "__x64_sys" prefix. > + */ > + return !strcmp(sym + 9, name + 3) || !strcmp(sym + 3, name + 3); > +} > > in place. >
Yeah, I did a test too, and found that I'm missing sys_clock_nanosleep. I'm looking into it.
-- Steve
| |