| Subject | Re: [PATCH 1/7] powerpc: Add TIDR CPU feature for Power9 | From | Andrew Donnellan <> | Date | Tue, 17 Apr 2018 14:09:41 +1000 |
| |
On 17/04/18 12:09, Alastair D'Silva wrote: > diff --git a/arch/powerpc/include/asm/switch_to.h b/arch/powerpc/include/asm/switch_to.h > index be8c9fa23983..5b03d8a82409 100644 > --- a/arch/powerpc/include/asm/switch_to.h > +++ b/arch/powerpc/include/asm/switch_to.h > @@ -94,6 +94,5 @@ static inline void clear_task_ebb(struct task_struct *t) > extern int set_thread_uses_vas(void); > > extern int set_thread_tidr(struct task_struct *t); > -extern void clear_thread_tidr(struct task_struct *t);
This hunk looks like it really belongs in patch 3.
Apart from that, I'm not really familiar with the CPU features code but nothing seems overly wrong...
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
-- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited
|