Messages in this thread Patch in this message | | | From | Andres Rodriguez <> | Subject | [PATCH 5/8] firmware: print firmware name on fallback path | Date | Mon, 16 Apr 2018 18:24:24 -0400 |
| |
Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d".
However, with the new firmware_request_nowarn() entrypoint, the message outlined above will not always be printed.
Therefore, we add the firmware name to the fallback path spew in order to associate it with the appropriate request.
Signed-off-by: Andres Rodriguez <andresx7@gmail.com> --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e5b0a96ae781 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -669,6 +669,6 @@ int fw_sysfs_fallback(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + dev_warn(device, "Falling back to user helper for %s\n", name); return fw_load_from_user_helper(fw, name, device, opt_flags); } -- 2.14.1
| |