Messages in this thread | | | Subject | Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard | From | Robert Munteanu <> | Date | Tue, 17 Apr 2018 00:35:29 +0300 |
| |
On Mon, 2018-04-16 at 15:36 +0200, Benjamin Tissoires wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > The SPDX header says GPL-v2. And IIRC if there is the SPDX header > > > you > > > can drop the MODULE_LICENSE (not entirely sure though). > > > > Ack, will adjust and re-test. > > Actually, you might be correct. I just read Mauro's blog: > https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx > / > and it says "Types of licenses for MODULE_LICENSE() macro -> 'GPL' -> > GNU Public License v2 or later" (in the second table).
Currently the header says 'SPDX-License-Identifier: GPL-2.0', which is 'GNU General Public License v2.0 only' according to
https://spdx.org/licenses/
So we can't use that with MODULE_LICENSE("GPL") which means 'GNU General Public License v2.0 or later' . I don't have a strong preference for either, but I'll go with the 'or later' part since that seems to be more in favour ( shorter argument for the MODULE_LICENSE macro ).
Robert
| |