Messages in this thread | | | Date | Mon, 16 Apr 2018 22:50:10 +0530 | From | saiprakash.ranjan@codeauro ... | Subject | Re: [PATCH v4 2/2] drivers: soc: Add LLCC driver |
| |
Hi Rishabh,
> +MODULE_DESCRIPTION("QTI sdm845 LLCC driver");
I think it should be QCOM or Qualcomm and not QTI
> + > + desc = devm_kzalloc(dev, sizeof(struct llcc_slice_desc), GFP_KERNEL);
Can use *desc instead
> +struct llcc_slice_desc *llcc_slice_getd(struct device *dev, const char > *name) > +{ > + struct device_node *np = dev->of_node; > + int index = 0; > + const char *slice_name; > + struct property *prop; > + > + if (!np) > + return ERR_PTR(-ENOENT);
Is this check required?
> diff --git a/include/linux/soc/qcom/llcc-qcom.h > b/include/linux/soc/qcom/llcc-qcom.h > new file mode 100644 > index 0000000..3e97569 > --- /dev/null > +++ b/include/linux/soc/qcom/llcc-qcom.h > @@ -0,0 +1,168 @@ > +// SPDX-License-Identifier: GPL-2.0
Should be within /* */ for headers as per kernel licensing rules.
Regards, Sai Prakash
| |