lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 2/2] drivers: soc: Add LLCC driver
    Hi Rishabh,

    > +MODULE_DESCRIPTION("QTI sdm845 LLCC driver");

    I think it should be QCOM or Qualcomm and not QTI

    > +
    > + desc = devm_kzalloc(dev, sizeof(struct llcc_slice_desc), GFP_KERNEL);

    Can use *desc instead

    > +struct llcc_slice_desc *llcc_slice_getd(struct device *dev, const char
    > *name)
    > +{
    > + struct device_node *np = dev->of_node;
    > + int index = 0;
    > + const char *slice_name;
    > + struct property *prop;
    > +
    > + if (!np)
    > + return ERR_PTR(-ENOENT);

    Is this check required?

    > diff --git a/include/linux/soc/qcom/llcc-qcom.h
    > b/include/linux/soc/qcom/llcc-qcom.h
    > new file mode 100644
    > index 0000000..3e97569
    > --- /dev/null
    > +++ b/include/linux/soc/qcom/llcc-qcom.h
    > @@ -0,0 +1,168 @@
    > +// SPDX-License-Identifier: GPL-2.0

    Should be within /* */ for headers as per kernel licensing rules.

    Regards,
    Sai Prakash

    \
     
     \ /
      Last update: 2018-04-16 19:21    [W:3.170 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site