Messages in this thread | | | Date | Mon, 16 Apr 2018 08:10:44 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/4] x86/crypto: camellia: Fix function prototypes |
| |
* Joao Moreira <jmoreira@suse.de> wrote:
> Convert the use of 'struct camellia_ctx *' to 'void *' in prototypes of > functions which are referenced through 'struct common_glue_func_entry', > making their prototypes match those of this struct and, consequently, > turning them compatible with CFI requirements. > > Whenever needed, cast 'void *' to 'struct camellia_ctx *'.
> +static inline void camellia_enc_blk(void *ctx, u8 *dst, const u8 *src) > { > - __camellia_enc_blk(ctx, dst, src, false); > + __camellia_enc_blk((struct camellia_ctx *) ctx, dst, src, false); > }
I don't see how this is an improvement: instead of having a proper type there's now an opaque type and an ugly (and dangerous) type cast.
What does "compatible with CFI requirements" mean?
Thanks,
Ingo
| |