Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file | Date | Mon, 16 Apr 2018 16:24:50 +0200 |
| |
On Monday, April 16, 2018 03:24:57 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > exynos_tmu.h is used only by exynos_tmu.c so there is no need > > for a separate include file. > > > > There should be no functional changes caused by this patch. > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > --- > > drivers/thermal/samsung/exynos_tmu.c | 18 +++++++++++++++- > > drivers/thermal/samsung/exynos_tmu.h | 41 ------------------------------------ > > 2 files changed, 17 insertions(+), 42 deletions(-) > > delete mode 100644 drivers/thermal/samsung/exynos_tmu.h > > > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > > index 7975f33..197f267 100644 > > --- a/drivers/thermal/samsung/exynos_tmu.c > > +++ b/drivers/thermal/samsung/exynos_tmu.c > > @@ -34,8 +34,10 @@ > > #include <linux/of_irq.h> > > #include <linux/platform_device.h> > > #include <linux/regulator/consumer.h> > > +#include <linux/cpu_cooling.h> > > + > > This one should go away, no ?
Yes, thanks for noticing (I've just sent v2 of this patch). . > Apart this. > > Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |