lkml.org 
[lkml]   [2018]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/22] staging: lustre: llite: remove newline in fullname strings
    Date
    In creating the full name of a xattr a new line was added that
    was seen by the remote MDS server which confused it. Remove the
    newline.

    Signed-off-by: James Simmons <uja.ornl@yahoo.com>
    Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9183
    Reviewed-on: https://review.whamcloud.com/27240
    Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
    Reviewed-by: Bob Glossman <bob.glossman@intel.com>
    Reviewed-by: Sebastien Buisson <sbuisson@ddn.com>
    Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
    Signed-off-by: James Simmons <jsimmons@infradead.org>
    ---
    drivers/staging/lustre/lustre/llite/xattr.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c
    index 42a6fb4..4b1e565 100644
    --- a/drivers/staging/lustre/lustre/llite/xattr.c
    +++ b/drivers/staging/lustre/lustre/llite/xattr.c
    @@ -136,7 +136,7 @@ static int xattr_type_filter(struct ll_sb_info *sbi,
    return -EPERM;
    }

    - fullname = kasprintf(GFP_KERNEL, "%s%s\n", handler->prefix, name);
    + fullname = kasprintf(GFP_KERNEL, "%s%s", handler->prefix, name);
    if (!fullname)
    return -ENOMEM;
    rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode),
    @@ -435,7 +435,7 @@ static int ll_xattr_get_common(const struct xattr_handler *handler,
    if (handler->flags == XATTR_ACL_DEFAULT_T && !S_ISDIR(inode->i_mode))
    return -ENODATA;
    #endif
    - fullname = kasprintf(GFP_KERNEL, "%s%s\n", handler->prefix, name);
    + fullname = kasprintf(GFP_KERNEL, "%s%s", handler->prefix, name);
    if (!fullname)
    return -ENOMEM;
    rc = ll_xattr_list(inode, fullname, handler->flags, buffer, size,
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2018-04-16 06:18    [W:4.256 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site