Messages in this thread | | | Date | Mon, 16 Apr 2018 13:31:02 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v3 6/7] thermal/drivers/cpu_cooling: Introduce the cpu idle cooling driver |
| |
On Mon, Apr 16, 2018 at 02:10:30PM +0200, Daniel Lezcano wrote: > On 16/04/2018 12:10, Viresh Kumar wrote: > > On 16-04-18, 12:03, Daniel Lezcano wrote: > >> On 16/04/2018 11:50, Viresh Kumar wrote: > >>> On 16-04-18, 11:45, Daniel Lezcano wrote: > >>>> Can you elaborate a bit ? I'm not sure to get the point. > >>> > >>> Sure. With your current code on Hikey960 (big/LITTLE), you end up > >>> creating two cooling devices, one for the big cluster and one for > >>> small cluster. Which is the right thing to do, as we also have two > >>> cpufreq cooling devices. > >>> > >>> But with the change Sudeep is referring to, the helper you used to get > >>> cluster id will return 0 (SoC id) for all the 8 CPUs. So your code > >>> will end up creating a single cpuidle cooling device for all the CPUs. > >>> Which would be wrong. > >> > >> Is the semantic of topology_physical_package_id changing ? > > > > That's what I understood from his email. > > > >> I don't > >> understand the change Sudeep is referring to. > > Actually there is no impact with the change Sudeep is referring to. It > is for ACPI, we are DT based. Confirmed with Jeremy. >
No, it will change for DT. The aim is to be consistent irrespective of h/w or f/w description(i.e ADCPI or DT)
-- Regards, Sudeep
| |