Messages in this thread | | | From | Benjamin Tissoires <> | Date | Mon, 16 Apr 2018 11:56:03 +0200 | Subject | Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard |
| |
On Mon, Apr 16, 2018 at 11:49 AM, Jiri Kosina <jikos@kernel.org> wrote: > On Wed, 11 Apr 2018, Robert Munteanu wrote: > >> Changelog: >> >> - v2: modifier keys work, some combinations are still troublesome >> - v3: style cleanup, rebase on top of 4.14 >> - v4: remove most debugging calls, make init info useful for user, >> rebased on top of 4.15 >> - v5: fix the HID descriptor as suggested by Benjamin Tissoires, >> use existing USB vendor id, update comment style, add SPDX >> license identifier, rename to hid-redragon, stop registering >> two input devices, rebased on top of 4.16 > > This should contain the text that goes directly into the git commit > changelog, therefore should instead contain something like "This adds a > news driver for HW XX, that needs a specialized driver bacuse .... and > things to specifically point out in implementation are ....". > > Could you please provide that, so that I can commit it?
Jiri, please hold off, I have a few comments while quickly reviewing the patch.
Cheers, Benjamin
> > Thanks. > > -- > Jiri Kosina > SUSE Labs >
| |