Messages in this thread Patch in this message | | | Subject | Re: [PATCH v3] mm/page_owner: ignore everything below the IRQ entry point | From | Maninder Singh <> | Date | Mon, 16 Apr 2018 11:14:59 +0530 |
| |
Hi Arnd,
We sent one patch for ignoring entries below IRQ point in page_onwer using stackdepot.
V2:- https://lkml.org/lkml/2018/3/26/178
V3:- https://lkml.org/lkml/2018/3/27/357
But it's breaking build for um target with below reason.
kernel/stacktrace.o: In function `filter_irq_stacks': >> stacktrace.c:(.text+0x20e): undefined reference to `__irqentry_text_start' >> stacktrace.c:(.text+0x218): undefined reference to `__irqentry_text_end' >> stacktrace.c:(.text+0x222): undefined reference to `__softirqentry_text_start' >> stacktrace.c:(.text+0x22c): undefined reference to `__softirqentry_text_end' collect2: error: ld returned 1 exit status
So can we add below fix for this build break, can you suggest if it is ok or we need to find some other way:-
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h index 76b63f5..0f3b7f8 100644 --- a/include/asm-generic/vmlinux.lds.h +++ b/include/asm-generic/vmlinux.lds.h @@ -460,6 +460,10 @@ * to use ".." first. */ #define TEXT_TEXT \ + VMLINUX_SYMBOL(__irqentry_text_start) = .; \ + VMLINUX_SYMBOL(__irqentry_text_end) = .; \ + VMLINUX_SYMBOL(__softirqentry_text_start) = .; \ + VMLINUX_SYMBOL(__softirqentry_text_end) = .; \ ALIGN_FUNCTION(); \ *(.text.hot TEXT_MAIN .text.fixup .text.unlikely) \ *(.text..refcount) \ diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
To make solution generic for all architecture we declared 4 dummy variables which we used in our patch.
Thanks , Maninder Singh
| |