lkml.org 
[lkml]   [2018]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] aio: remove an outdated BUG_ON and comment in aio_complete
    Date
    These days we don't treat sync iocbs special in the aio completion code as
    they never use it. Remove the old comment and BUG_ON given that the
    current definition of is_sync_kiocb makes it impossible to hit.

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    ---
    fs/aio.c | 9 ---------
    1 file changed, 9 deletions(-)

    diff --git a/fs/aio.c b/fs/aio.c
    index add46b06be86..7c1855afd723 100644
    --- a/fs/aio.c
    +++ b/fs/aio.c
    @@ -1107,15 +1107,6 @@ static void aio_complete(struct kiocb *kiocb, long res, long res2)
    file_end_write(file);
    }

    - /*
    - * Special case handling for sync iocbs:
    - * - events go directly into the iocb for fast handling
    - * - the sync task with the iocb in its stack holds the single iocb
    - * ref, no other paths have a way to get another ref
    - * - the sync task helpfully left a reference to itself in the iocb
    - */
    - BUG_ON(is_sync_kiocb(kiocb));
    -
    if (iocb->ki_list.next) {
    unsigned long flags;

    --
    2.17.0
    \
     
     \ /
      Last update: 2018-04-15 17:04    [W:2.182 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site