Messages in this thread Patch in this message |  | | From | Jiri Olsa <> | Subject | [PATCH 1/3] perf: Return proper values for user stack errors | Date | Sun, 15 Apr 2018 11:23:50 +0200 |
| |
Return immediately when we find issue in the user stack checks. The error value could get overwritten by following check for PERF_SAMPLE_REGS_INTR.
Signed-off-by: Jiri Olsa <jolsa@kernel.org> --- kernel/events/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index fc1c330c6bd6..4d997bc064d2 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -10191,9 +10191,9 @@ static int perf_copy_attr(struct perf_event_attr __user *uattr, * __u16 sample size limit. */ if (attr->sample_stack_user >= USHRT_MAX) - ret = -EINVAL; + return -EINVAL; else if (!IS_ALIGNED(attr->sample_stack_user, sizeof(u64))) - ret = -EINVAL; + return -EINVAL; } if (!attr->sample_max_stack) -- 2.13.6
|  |