Messages in this thread | | | Date | Fri, 13 Apr 2018 20:11:23 -0500 | From | Shiraz Saleem <> | Subject | Re: [PATCH 2/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_make_listen_node |
| |
On Wed, Apr 11, 2018 at 03:32:48PM +0800, Jia-Ju Bai wrote: > i40iw_make_listen_node() is never called in atomic context. > > i40iw_make_listen_node() is only called by i40iw_create_listen, which is > set as ".create_listen" in struct iw_cm_verbs. > > Despite never getting called from atomic context, > i40iw_make_listen_node() calls kzalloc() with GFP_ATOMIC, > which does not sleep for allocation. > GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, > which can sleep and improve the possibility of sucessful allocation. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> > --- >
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
| |