Messages in this thread Patch in this message | | | From | Song Liu <> | Subject | [PATCH] trace_kprobe: Remove warning message "Could not insert probe at..." | Date | Fri, 13 Apr 2018 11:55:13 -0700 |
| |
This warning message is not very helpful, as the return value should already show information about the error. Also, this message will flush dmesg if the user space do something silly in a loop, like:
for x in {0..5} do echo p:xx xx+$x >> /sys/kernel/debug/tracing/kprobe_events done
Cc: Ingo Molnar <mingo@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Reported-by: Vince Weaver <vincent.weaver@maine.edu> Signed-off-by: Song Liu <songliubraving@fb.com> --- kernel/trace/trace_kprobe.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index 1cd3fb4..02aed76 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -512,8 +512,6 @@ static int __register_trace_kprobe(struct trace_kprobe *tk) if (ret == 0) tk->tp.flags |= TP_FLAG_REGISTERED; else { - pr_warn("Could not insert probe at %s+%lu: %d\n", - trace_kprobe_symbol(tk), trace_kprobe_offset(tk), ret); if (ret == -ENOENT && trace_kprobe_is_on_module(tk)) { pr_warn("This probe might be able to register after target module is loaded. Continue.\n"); ret = 0; -- 2.9.5
| |