lkml.org 
[lkml]   [2018]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spi: cadence: Add usleep_range() for cdns_spi_fill_tx_fifo()
On Mon, Apr 09, 2018 at 07:16:50PM +0800, sxauwsk wrote:
> In case of xspi work in busy condition, may send bytes failed.
> Add one bytes delay

> while ((trans_cnt < CDNS_SPI_FIFO_DEPTH) &&
> (xspi->tx_bytes > 0)) {
> +
> + /* When xspi in busy condition, bytes may send failed,
> + * caused communication failure so add one byte delay
> + */
> + usleep_range(10, 20);
> +
> if (xspi->txbuf)
> cdns_spi_write(xspi, CDNS_SPI_TXD, *xspi->txbuf++);

This looks like it adds a byte of delay on every read/write - that
seems like a lot of overhead for something that sounds like it's
probably only an issue when the FIFO is full? Do we need to do this for
every operation, and is it needed for read or is it just write?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-04-13 20:03    [W:0.029 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site