lkml.org 
[lkml]   [2018]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/3] Documentation/i2c: adopt kernel commenting style in examples
On Fri, Apr 13, 2018 at 9:50 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> - int adapter_nr = 2; /* probably dynamically determined */
>
> Such comments are actually OK.

Ah, gotcha. Thanks for the correction. Standby for revised patch set.

>
>> - /* ERROR HANDLING; you can check errno to see what went wrong */
>
> Such as well.
>
>> - /* Using I2C Write, equivalent of
>> - i2c_smbus_write_word_data(file, reg, 0x6543) */
>> + /*
>> + * Using I2C Write, equivalent of
>> + * i2c_smbus_write_word_data(file, reg, 0x6543).
>> + */
>
> This is the only broken one AFAICT.
>

\
 
 \ /
  Last update: 2018-04-13 19:40    [W:0.121 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site