[lkml]   [2018]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] X86/KVM: Properly update 'tsc_offset' to represent the running guest
On 13/04/2018 14:40, Raslan, KarimAllah wrote:
>> static void update_ia32_tsc_adjust_msr(struct kvm_vcpu *vcpu, s64 offset)
>> {
>> - u64 curr_offset = vcpu->arch.tsc_offset;
>> + u64 curr_offset = kvm_x86_ops->read_l1_tsc_offset(vcpu);
> I might be missing something but is this really strictly needed or is
> it really a bug?
> I can see update_ia32_tsc_adjust_msr called from kvm_write_tsc only 
> which is called from a) vmx_set_msr or b) kvm_arch_vcpu_postcreate.
> The adjust_msr would only be called if !host_initiated. So only 
> vmx_set_msr which is coming from an L1 write (or a restore but that
> would not be !host_initiated). So the only that tsc_adjust is called is
> !is_guest_mode.

It can also be called from guest mode if the MSR bitmap says there's no
L1 vmexit for that MSR; that's what the testcases do.


>> vcpu->arch.ia32_tsc_adjust_msr += offset - curr_offset;

 \ /
  Last update: 2018-04-13 17:36    [W:0.055 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site