Messages in this thread | | | Date | Fri, 13 Apr 2018 14:58:01 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/3] perf/buildid-cache: Support --list option |
| |
On Mon, Apr 09, 2018 at 04:36:32PM +0530, Ravi Bangoria wrote:
SNIP
> - !remove_name_list_str && !purge_name_list_str && > - !missing_filename && !update_name_list_str)) > + opts_flag = add_name_list_str || kcore_filename || > + remove_name_list_str || purge_name_list_str || > + missing_filename || update_name_list_str; > + > + if (argc || !(list_files || opts_flag)) > usage_with_options(buildid_cache_usage, buildid_cache_options); > > + /* -l is exclusive. It can not be used with other options. */ > + if (list_files && opts_flag) > + usage_with_options_msg(buildid_cache_usage, > + buildid_cache_options, "-l is exclusive.\n"); > + > if (ns_id > 0) > nsi = nsinfo__new(ns_id); > > @@ -366,6 +396,11 @@ int cmd_buildid_cache(int argc, const char **argv) > > setup_pager(); > > + if (list_files) { > + build_id_cache__show_all(); > + goto out;
make build_id_cache__show_all return value and store it to ret before going out
jirka
| |