Messages in this thread | | | Subject | Re: [GIT PULL] Thermal management updates for v4.17-rc1 | From | Daniel Lezcano <> | Date | Fri, 13 Apr 2018 12:30:04 +0200 |
| |
On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote:
[ ... ]
>>> It is okay to return 0 because this code-path (the default one) will be >>> never hit by the driver (probe makes sure of it) - the default case is >>> here is just to silence compilation errors.. >> >> The init function is making sure cal_type is one or another. Can you fix >> it correctly by replacing the 'switch' by a 'if' instead of adding dead >> branches to please gcc? >> >> if (data->cal_type == TYPE_TWO_POINT_TRIMMING) { >> return ...; >> } >> >> return ...; > > I'm not the one that added this switch statement (it has been there since > 2011) and I would be happy to remove it.
Actually the switch statement was fine until the cleanup.
> However could we please defer > this to v4.17 and merge the current set of Exynos thermal fixes/cleanups > (they simplify the driver a lot and make ground for future changes)?
Regarding the latest comment, this can be fixed properly by 'return' (or whatever you want which does not get around of gcc warnings).
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |