Messages in this thread | | | From | Masahiro Yamada <> | Date | Thu, 12 Apr 2018 18:08:58 +0900 | Subject | Re: [PATCH] ARM: omap2: Fix build when using split object directories |
| |
2018-04-12 17:21 GMT+09:00 Anders Roxell <anders.roxell@linaro.org>: > On 2018-04-11 16:15, Dave Gerlach wrote: >> The sleep33xx and sleep43xx files should not depend on a header file >> generated in drivers/memory. Remove this dependency and instead allow >> both drivers/memory and arch/arm/mach-omap2 to generate all macros >> needed in headers local to their own paths. >> >> This fixes an issue where the build fail will when using O= to set a >> split object directory and arch/arm/mach-omap2 is built before >> drivers/memory with the following error: >> >> .../drivers/memory/emif-asm-offsets.c:1:0: fatal error: can't open drivers/memory/emif-asm-offsets.s for writing: No such file or directory >> compilation terminated. >> >> Fixes: 41d9d44d7258 ("ARM: OMAP2+: pm33xx-core: Add platform code needed for PM") >> Acked-by: Tony Lindgren <tony@atomide.com> >> Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> > > Tested-by: Anders Roxell <anders.roxell@linaro.org> > > Maybe we can remove drivers/memory/Makefile.asm-offsets and move those > changes into drivers/memory/Makefile ?
Agree!
-- Best Regards Masahiro Yamada
| |