Messages in this thread | | | Date | Wed, 11 Apr 2018 09:08:20 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH 2/2] staging: irda: Replace mdelay with usleep_range in irda_usb_probe |
| |
On Wed, Apr 11, 2018 at 09:33:55AM +0800, Jia-Ju Bai wrote: > irda_usb_probe() is never called in atomic context. > > irda_usb_probe() is only set as ".probe" in struct usb_driver. > > Despite never getting called from atomic context, irda_usb_probe() > calls mdelay() to busily wait. > This is not necessary and can be replaced with usleep_range() to > avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
| |