lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 180/190] net: fool proof dev_valid_name()
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>


    [ Upstream commit a9d48205d0aedda021fc3728972a9e9934c2b9de ]

    We want to use dev_valid_name() to validate tunnel names,
    so better use strnlen(name, IFNAMSIZ) than strlen(name) to make
    sure to not upset KASAN.

    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/core/dev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/core/dev.c
    +++ b/net/core/dev.c
    @@ -989,7 +989,7 @@ bool dev_valid_name(const char *name)
    {
    if (*name == '\0')
    return false;
    - if (strlen(name) >= IFNAMSIZ)
    + if (strnlen(name, IFNAMSIZ) == IFNAMSIZ)
    return false;
    if (!strcmp(name, ".") || !strcmp(name, ".."))
    return false;

    \
     
     \ /
      Last update: 2018-04-11 20:53    [W:4.055 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site