Messages in this thread | | | Date | Wed, 11 Apr 2018 08:56:43 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] usb: serial: option: add HP LT4220 support |
| |
On Wed, Apr 11, 2018 at 02:36:52PM +0800, Edward Chang wrote: > This patch adds support for HP LT4220 > > Signed-off-by: Edward Chang <edward.chang.mcs@gmail.com> > ---
Thanks for the update. Please always include a changelog here when revising patches so we know what has changed since the previous version(s). Also include the patch version in the subject line (e.g. "[PATCH v2] USB: ...").
> drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index c3f2522..d866cc0 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -1927,6 +1927,8 @@ static int option_probe(struct usb_serial *serial, > { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_6802, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD300, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(0x03f0, 0x421d, 0xff, 0xff, 0xff) }, /* HP lt2523 (Novatel E371) */ > + { USB_DEVICE_INTERFACE_CLASS(0x03f0, 0x0857, 0xff), /* HP lt4220 */ > + .driver_info = (kernel_ulong_t)&telit_le920a4_blacklist_1 },
So you dropped the id defines, but this still would not compile due to the updated blacklist mechanism I mentioned. Take a look at the commit I referred to for examples of how to specify the blacklist masks.
Thanks, Johan
| |