Messages in this thread | | | Subject | Re: [PATCH 2/2] input: touchscreen mc13xxx: Add mc34708 support | From | Joe Perches <> | Date | Wed, 11 Apr 2018 09:01:01 -0700 |
| |
On Wed, 2018-04-11 at 16:13 +0200, Lukasz Majewski wrote: > From: Sascha Hauer <s.hauer@pengutronix.de> > > The mc34708 has a different bit to enable pen detection. This > adds the driver data and devtype necessary to probe the device > and to distinguish between the mc13783 and the mc34708.
style trivia:
> diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c [] > @@ -96,6 +135,10 @@ static void mc13783_ts_report_sample(struct mc13783_ts_priv *priv) > > cr0 = (cr0 + cr1) / 2; > > + if (priv->drvdata->type == MC13XXX_TYPE_MC34708) > + if (cr0 > 4080) > + cr0 = 0;
For easy of reading, this multiple if block should either use braces around the first if like:
if (foo) { if (bar) single_statement; }
or be written
if (foo && bar) single_statement;
I generally prefer the latter style.
| |