lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 0/2] iio: add unit converter
From
Date
On 04/11/2018 09:15 AM, Peter Rosin wrote:
> Hi!
>
> I'm now following up with one more binding for the unit-converter.
> This time with a real IC, namely LT6106 from Analog Devices.

This makes more sense to me, I wasn't thinking about more complex ICs
like this when I made my "resistor being part of the sensing device"
argument.

I can see how having a new node will probably be needed. It just seems
strange to ask a resistor for its current, although it is the "device"
that "knows" how much current if flowing though it..

A case I'm more familiar with, fuel gauges, we have a gauge device that
has a handle to the battery it is gauging [0], we still ask the
"fuel-gauge" node to get out the state of charge, not the "battery"
node, the battery is not a "device" from our perspective.

Thinking more about that, I like your way better, so I recant my earlier
objections.

Andrew

[0] Documentation/devicetree/bindings/power/supply/bq27xxx.txt

> It's
> a current sense amplifier. I was a but unsure if I should have
> the Rin and Rout resistors in the binding or if I instead should
> have used the "gain". In the end I went with the resistors since
> while the normal case is an integer gain, that may not always be
> the case. And when it's not, that could get tricky. But I'm open
> for arguments on that.
>
> Cheers,
> Peter
>
> Peter Rosin (2):
> dt-bindings: iio: afe: add binding for adi,lt6106
> iio: afe: unit-converter: add support for adi,lt6106
>
> .../devicetree/bindings/iio/afe/adi,lt6106.txt | 50 ++++++++++++++++++++
> MAINTAINERS | 1 +
> drivers/iio/afe/Kconfig | 3 +-
> drivers/iio/afe/iio-unit-converter.c | 54 ++++++++++++++++++++++
> 4 files changed, 107 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/iio/afe/adi,lt6106.txt
>

\
 
 \ /
  Last update: 2018-04-11 17:36    [W:0.147 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site