lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] blk-cgroup: remove entries in blkg_tree before queue release
    Hello,

    (cc'ing Bart)

    On Wed, Apr 11, 2018 at 07:46:16AM -0700, Tejun Heo wrote:
    > Hello,
    >
    > On Wed, Apr 11, 2018 at 04:28:59PM +0200, Alexandru Moise wrote:
    > > > Ah, that changed recently. Can you please check out the current
    > > > upstream git master?
    > > >
    > > Just did, without my patch I see this crash:
    >
    > lol I was looking at the old tree, so this is the fix for the new
    > breakage introduced by the recent change. Sorry about the confusion.
    > Joseph, can you please take a look?

    Oh, it wasn't Joseph's change. It was Bart's fix for a problem
    reported by Joseph. Bart, a063057d7c73 ("block: Fix a race between
    request queue removal and the block cgroup controller") created a
    regression where a request_queue can be destroyed with blkgs still
    attached. The original report is..

    http://lkml.kernel.org/r/20180407102148.GA9729@gmail.com

    Thanks.

    --
    tejun

    \
     
     \ /
      Last update: 2018-04-11 16:52    [W:3.219 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site