lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 3/7] sched/fair: Consider misfit tasks when load-balancing
On Thu, Mar 15, 2018 at 02:47:00PM +0000, Morten Rasmussen wrote:
> + /*
> + * Don't try to pull misfit tasks we can't help.
> + */
> + if (sgs->group_type == group_misfit_task &&
> + (!group_smaller_cpu_capacity(sg, sds->local) ||
> + !group_has_capacity(env, &sds->local_stat)))
> + return false;
> +

I think that has the same 'problem' as last time, right? Since
group_smaller_cpu_capacity() is affected by RT/IRQ pressure.

We should have a comment stating this and preferably explaining why that
is ok.

\
 
 \ /
  Last update: 2018-04-11 12:54    [W:0.130 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site