Messages in this thread | | | Date | Wed, 11 Apr 2018 11:41:47 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 1/9] lib/test_printf: Mark big constant with ULL |
| |
On Mon 2018-02-19 17:24:22, Andy Shevchenko wrote: > On Sun, 2018-02-18 at 13:58 +0100, Luc Van Oostenryck wrote: > > On Fri, Feb 16, 2018 at 11:07:03PM +0200, Andy Shevchenko wrote: > > > Sparse complains that constant is so bit for unsigned long on 64-bit > > > architecture. > > > > > > lib/test_printf.c:217:54: warning: constant 0xffff0123456789ab is so > > > big it is unsigned long > > > lib/test_printf.c:246:54: warning: constant 0xffff0123456789ab is so > > > big it is unsigned long > > > > > > To satisfy everyone, mark the constant with ULL. > > > > It should be 'UL' not 'ULL' since for architectures a pointer and > > a unsigned long have the ame size while on 32bit archs, long long > > are (or may?) 64bit. > > Yes, UL works as well.
I have updated the patch and pushed it into printk.git, branch for-4.18-vsprintf-cleanup.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards, Petr
| |