lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 024/121] usb: dwc3: keystone: check return value
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pan Bian <bianpan2016@163.com>


    [ Upstream commit 018047a1dba7636e1f7fdae2cc290a528991d648 ]

    Function devm_clk_get() returns an ERR_PTR when it fails. However, in
    function kdwc3_probe(), its return value is not checked, which may
    result in a bad memory access bug. This patch fixes the bug.

    Signed-off-by: Pan Bian <bianpan2016@163.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/dwc3/dwc3-keystone.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/usb/dwc3/dwc3-keystone.c
    +++ b/drivers/usb/dwc3/dwc3-keystone.c
    @@ -117,6 +117,10 @@ static int kdwc3_probe(struct platform_d
    dev->dma_mask = &kdwc3_dma_mask;

    kdwc->clk = devm_clk_get(kdwc->dev, "usb");
    + if (IS_ERR(kdwc->clk)) {
    + dev_err(kdwc->dev, "unable to get usb clock\n");
    + return PTR_ERR(kdwc->clk);
    + }

    error = clk_prepare_enable(kdwc->clk);
    if (error < 0) {

    \
     
     \ /
      Last update: 2018-04-11 23:24    [W:4.065 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site