lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 053/121] hdlcdrv: Fix divide by zero in hdlcdrv_ioctl
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Firo Yang <firogm@gmail.com>


    [ Upstream commit fb3ce90b7d7761b6f7f28f0ff5c456ef6b5229a1 ]

    syszkaller fuzzer triggered a divide by zero, when set calibration
    through ioctl().

    To fix it, test 'bitrate' if it is negative or 0, just return -EINVAL.

    Reported-by: Andrey Konovalov <andreyknvl@google.com>
    Signed-off-by: Firo Yang <firogm@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/hamradio/hdlcdrv.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/hamradio/hdlcdrv.c
    +++ b/drivers/net/hamradio/hdlcdrv.c
    @@ -571,6 +571,8 @@ static int hdlcdrv_ioctl(struct net_devi
    case HDLCDRVCTL_CALIBRATE:
    if(!capable(CAP_SYS_RAWIO))
    return -EPERM;
    + if (s->par.bitrate <= 0)
    + return -EINVAL;
    if (bi.data.calibrate > INT_MAX / s->par.bitrate)
    return -EINVAL;
    s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;

    \
     
     \ /
      Last update: 2018-04-11 23:11    [W:4.111 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site