lkml.org 
[lkml]   [2018]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] ide: pdc202xx_new: Replace mdelay with msleep in init_chipset_pdcnew
Date
init_chipset_pdcnew() is never called in atomic context.
This function is only set as ".init_chipset" in struct ide_port_info.

Despite never getting called from atomic context, init_chipset_pdcnew()
calls mdelay() to busily wait.
This is not necessary and can be replaced with msleep() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/ide/pdc202xx_new.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/pdc202xx_new.c b/drivers/ide/pdc202xx_new.c
index b33646b..a654491 100644
--- a/drivers/ide/pdc202xx_new.c
+++ b/drivers/ide/pdc202xx_new.c
@@ -403,7 +403,7 @@ static int init_chipset_pdcnew(struct pci_dev *dev)
outb(pll_ctl1, sec_dma_base + 0x03);

/* Wait the PLL circuit to be stable */
- mdelay(30);
+ msleep(30);

#ifdef DEBUG
/*
--
1.9.1
\
 
 \ /
  Last update: 2018-04-11 09:54    [W:0.024 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site