Messages in this thread | | | Date | Tue, 10 Apr 2018 10:19:35 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH] firmware: dmi_scan: Fix UUID length safety check |
| |
On Mon, Apr 09, 2018 at 02:51:43PM +0200, Jean Delvare wrote: > The test which ensures that the DMI type 1 structure is long enough > to hold the UUID is off by one. It would fail if the structure is > exactly 24 bytes long, while that's sufficient to hold the UUID. > > I don't expect this bug to cause problem in practice because all > implementations I have seen had length 8, 25 or 27 bytes, in line > with the SMBIOS specifications. But let's fix it still. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Fixes: a814c3597a6b ("firmware: dmi_scan: Check DMI structure length") > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
| |