lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v29 1/4] mm: support reporting free page blocks
On Tue, 10 Apr 2018 21:19:31 +0300 "Michael S. Tsirkin" <mst@redhat.com> wrote:

>
> Andrew, were your questions answered? If yes could I bother you for an ack on this?
>

Still not very happy that readers are told that "this function may
sleep" when it clearly doesn't do so. If we wish to be able to change
it to sleep in the future then that should be mentioned. And even put a
might_sleep() in there, to catch people who didn't read the comments...

Otherwise it looks OK.

\
 
 \ /
  Last update: 2018-04-10 22:55    [W:0.269 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site