lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86: fix pgprotval_t format string
From
Date
On 04/10/2018 01:43 AM, Arnd Bergmann wrote:
> --- a/arch/x86/include/asm/pgtable.h
> +++ b/arch/x86/include/asm/pgtable.h
> @@ -533,11 +533,11 @@ static inline pgprotval_t check_pgprot(pgprot_t pgprot)
> /* mmdebug.h can not be included here because of dependencies */
> #ifdef CONFIG_DEBUG_VM
> WARN_ONCE(pgprot_val(pgprot) != massaged_val,
> - "attempted to set unsupported pgprot: %016lx "
> - "bits: %016lx supported: %016lx\n",
> - pgprot_val(pgprot),
> - pgprot_val(pgprot) ^ massaged_val,
> - __supported_pte_mask);
> + "attempted to set unsupported pgprot: %016llx "
> + "bits: %016llx supported: %016llx\n",
> + (u64)pgprot_val(pgprot),
> + (u64)pgprot_val(pgprot) ^ massaged_val,
> + (u64)__supported_pte_mask);
> #endif

Whoops, I just sent a similar patch. I just used 'unsigned long long'
instead of u64. I'm fine with this as well, and don't prefer one over
the other, so:

Acked-by: Dave Hansen <dave.hansen@linux.intel.com>

\
 
 \ /
  Last update: 2018-04-10 22:01    [W:0.245 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site