Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 10 Apr 2018 21:10:04 +0300 | Subject | Re: [PATCH v3 1/4] gpio: pca953x: set the PCA_PCAL flag also when matching by DT |
| |
On Tue, Apr 10, 2018 at 9:08 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Tue, Apr 10, 2018 at 7:07 PM, H. Nikolaus Schaller <hns@goldelico.com> wrote: >> The of_device_table is missing the PCA_PCAL flag so the >> pcal6524 would be operated in tca6424 compatibility mode which >> does not handle the new interrupt mask registers. > > >> + { .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_INT | >> + PCA_PCAL), }, >> + { .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_INT | >> + PCA_PCAL), }, > > Sorry didn't comment this earlier, though I think one line still > better to read disregard of 80 char limit.
Another possible solution:
#define PCA_LATCH_INT (PCA_PCAL | PCA_INT)
or alike
-- With Best Regards, Andy Shevchenko
| |