Messages in this thread | | | From | Fabio Estevam <> | Date | Tue, 10 Apr 2018 12:17:47 -0300 | Subject | Re: [alsa-devel] [PATCH] ASoC: fsl_esai: Fix divisor calculation failure at lower ratio |
| |
Hi Nicolin,
On Sun, Apr 8, 2018 at 8:57 PM, Nicolin Chen <nicoleotsuka@gmail.com> wrote: > When the desired ratio is less than 256, the savesub (tolerance) > in the calculation would become 0. This will then fail the loop- > search immediately without reporting any errors. > > But if the ratio is smaller enough, there is no need to calculate > the tolerance because PM divisor alone is enough to get the ratio. > > So a simple fix could be just to set PM directly instead of going > into the loop-search. > > Reported-by: Marek Vasut <marex@denx.de> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > Cc: Marek Vasut <marex@denx.de>
Thanks for the fix:
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
| |