lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] adp5061: New driver for ADP5061 I2C battery charger
On Wed, Apr 04, 2018 at 11:17:12AM +0300, Stefan Popa wrote:
> This patch adds basic support for Analog Devices I2C programmable linear
> battery charger.
>
> With this driver, some parameters can be read and configured such as:
> * trickle charge current level
> * trickle charge voltage threshold
> * weak charge threshold
> * constant current
> * constant charge voltage limit
> * battery full
> * input current limit
> * charger status
> * battery status
> * termination current

Don't you need to describe all these parameters of the battery used?
Charger bindings are never this simple.

>
> Datasheet:
> http://www.analog.com/media/en/technical-documentation/data-sheets/ADP5061.pdf
>
> Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> ---
> .../devicetree/bindings/power/supply/adp5061.txt | 17 +

Please split bindings to a separate patch.

> MAINTAINERS | 8 +
> drivers/power/supply/Kconfig | 11 +
> drivers/power/supply/Makefile | 1 +
> drivers/power/supply/adp5061.c | 745 +++++++++++++++++++++
> 5 files changed, 782 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/adp5061.txt
> create mode 100644 drivers/power/supply/adp5061.c
>
> diff --git a/Documentation/devicetree/bindings/power/supply/adp5061.txt b/Documentation/devicetree/bindings/power/supply/adp5061.txt
> new file mode 100644
> index 0000000..7447446
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adp5061.txt
> @@ -0,0 +1,17 @@
> +Analog Devices ADP5061 Programmable Linear Battery Charger Driver
> +
> +Required properties:
> + - compatible: should be "adi,adp5061"
> + - reg: i2c address of the device
> +
> +The node for this driver must be a child node of a I2C controller, hence
> +all mandatory properties described in
> +Documentation/devicetree/bindings/i2c/i2c.txt
> +must be specified.
> +
> +Example:
> +
> + adp5061@14 {
> + compatible = "adi,adp5061";
> + reg = <0x14>;
> + };

\
 
 \ /
  Last update: 2018-04-10 15:54    [W:0.491 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site