lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] X86/VMX: Disable VMX preempition timer if MWAIT is not intercepted
Date
On Tue, 2018-04-10 at 11:04 +0200, Paolo Bonzini wrote:
> On 10/04/2018 10:50, KarimAllah Ahmed wrote:
> >
> > WARN_ON(preemptible());
> > - if (!kvm_x86_ops->set_hv_timer)
> > + if (!kvm_x86_ops->has_hv_timer ||
> > + !kvm_x86_ops->has_hv_timer(apic->vcpu))
> > return false;
> >
> > if (!apic_lvtt_period(apic) && atomic_read(&ktimer->pending))
>
> Why not just return -ENOTSUP from vmx_set_hv_timer?

hehe .. good point :)

I just sent v2!

>
> Thanks,
>
> Paolo
>
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
\
 
 \ /
  Last update: 2018-04-10 12:11    [W:0.033 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site