lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped
    On Tue, Apr 10, 2018 at 9:33 AM,  <yuankuiz@codeaurora.org> wrote:
    > From: John Zhao <yuankuiz@codeaurora.org>
    >
    > Variable tick_stopped returned by tick_nohz_tick_stopped
    > can have only true / forse values. Since the return type
    > of the tick_nohz_tick_stopped is also bool, variable
    > tick_stopped nice to have data type as bool in place of int.
    > Moreover, the executed instructions cost could be minimal
    > without potiential data type conversion.
    >
    > Signed-off-by: John Zhao <yuankuiz@codeaurora.org>
    > ---
    > kernel/time/tick-sched.h | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/kernel/time/tick-sched.h b/kernel/time/tick-sched.h
    > index 6de959a..4d34309 100644
    > --- a/kernel/time/tick-sched.h
    > +++ b/kernel/time/tick-sched.h
    > @@ -48,8 +48,8 @@ struct tick_sched {
    > unsigned long check_clocks;
    > enum tick_nohz_mode nohz_mode;
    >
    > + bool tick_stopped : 1;
    > unsigned int inidle : 1;
    > - unsigned int tick_stopped : 1;
    > unsigned int idle_active : 1;
    > unsigned int do_timer_last : 1;
    > unsigned int got_idle_tick : 1;

    I don't think this is a good idea at all.

    Please see https://lkml.org/lkml/2017/11/21/384 for example.

    Thanks!

    \
     
     \ /
      Last update: 2018-04-10 10:00    [W:5.360 / U:0.576 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site