lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 3/3] mmc: wbsd: Replace mdelay with usleep_range in wbsd_pnp_resume
Date
wbsd_pnp_resume() is never called in atomic context.
This function is only set as ".resume" in struct pnp_driver.

Despite never getting called from atomic context, wbsd_pnp_resume()
calls mdelay() to busily wait.
This is not necessary and can be replaced with usleep_range() to
avoid busy waiting.

This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/mmc/host/wbsd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 546aaf8..83e13cf 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -1890,7 +1890,7 @@ static int wbsd_pnp_resume(struct pnp_dev *pnp_dev)
/*
* Allow device to initialise itself properly.
*/
- mdelay(5);
+ usleep_range(5000, 6000);

wbsd_init_device(host);
return 0;
--
1.9.1
\
 
 \ /
  Last update: 2018-04-11 04:47    [W:0.028 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site