lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped
    On Tue, 10 Apr 2018, yuankuiz@codeaurora.org wrote:

    > From: John Zhao <yuankuiz@codeaurora.org>
    >
    > Variable tick_stopped returned by tick_nohz_tick_stopped
    > can have only true / forse values. Since the return type
    > of the tick_nohz_tick_stopped is also bool, variable
    > tick_stopped nice to have data type as bool in place of int.

    The data type is not int. It's part of an integer bitfield and occupies
    exactly one bit of storage, while bool has an architecture dependend size
    and is at least 1 byte, i.e. 8 bit. So with alignment effects you grew the
    size of the data structure and therefore the cache foot print.

    This is not about 'nice to have' ....

    Thanks,

    tglx

    \
     
     \ /
      Last update: 2018-04-10 09:57    [W:6.108 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site