lkml.org 
[lkml]   [2018]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 034/168] ASoC: Intel: Skylake: Disable clock gating during firmware and library download
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>


    [ Upstream commit d5cc0a1fcbb5ddbef9fdd4c4a978da3254ddbf37 ]

    During firmware and library download, sometimes it is observed that
    firmware and library download is timed-out resulting into probe failure.

    This patch disables dynamic clock gating while firmware and library
    download.

    Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
    Signed-off-by: Sanyog Kale <sanyog.r.kale@intel.com>
    Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
    Acked-By: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/soc/intel/skylake/skl-messages.c | 4 ++++
    sound/soc/intel/skylake/skl-pcm.c | 4 ++++
    2 files changed, 8 insertions(+)

    --- a/sound/soc/intel/skylake/skl-messages.c
    +++ b/sound/soc/intel/skylake/skl-messages.c
    @@ -404,7 +404,11 @@ int skl_resume_dsp(struct skl *skl)
    if (skl->skl_sst->is_first_boot == true)
    return 0;

    + /* disable dynamic clock gating during fw and lib download */
    + ctx->enable_miscbdcge(ctx->dev, false);
    +
    ret = skl_dsp_wake(ctx->dsp);
    + ctx->enable_miscbdcge(ctx->dev, true);
    if (ret < 0)
    return ret;

    --- a/sound/soc/intel/skylake/skl-pcm.c
    +++ b/sound/soc/intel/skylake/skl-pcm.c
    @@ -1343,7 +1343,11 @@ static int skl_platform_soc_probe(struct
    return -EIO;
    }

    + /* disable dynamic clock gating during fw and lib download */
    + skl->skl_sst->enable_miscbdcge(platform->dev, false);
    +
    ret = ops->init_fw(platform->dev, skl->skl_sst);
    + skl->skl_sst->enable_miscbdcge(platform->dev, true);
    if (ret < 0) {
    dev_err(platform->dev, "Failed to boot first fw: %d\n", ret);
    return ret;

    \
     
     \ /
      Last update: 2018-04-11 01:34    [W:4.116 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site