Messages in this thread | | | Subject | Re: WARNING in __proc_create | From | Eric Dumazet <> | Date | Fri, 9 Mar 2018 15:42:53 -0800 |
| |
On 03/09/2018 03:32 PM, Cong Wang wrote: > On Fri, Mar 9, 2018 at 3:21 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote: >> >> >> On 03/09/2018 03:05 PM, Cong Wang wrote: >>> >>> >>> BTW, the warning itself is all about empty names, so perhaps >>> it's better to fix them separately. >> >> >> Huh ? You want more syzbot reports ? I do not. > > I always prefer one patch to fix one problem, and, as I already said, > checking "." and ".." is probably not as trivial as checking empty. > > This why I believe 2 (or more) patches here are better than 1 single > patch. > > BTW, I don't have any patch, it is so trivial that I don't want to spend > my time on it.
The trivial patch has been sent, and Florian gave a (very good) feedback.
Then Pablo offered to write a complete patch.
They both had more pressing issues, and quite frankly I also had more pressing issues.
I doubt that sending again the simple fix will be accepted by netfilter maintainers.
| |